[Docs] LSPS2: Improve invoice_parameters_generated docs #3871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On invoice_parameters_generated, explicitly mention that the intercept SCID needs to be retrieved from ChannelManager::get_intercept_scid.
|
👋 Thanks for assigning @tnull as a reviewer! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3871 +/- ##
==========================================
- Coverage 89.75% 89.73% -0.03%
==========================================
Files 164 164
Lines 132834 133079 +245
Branches 132834 133079 +245
==========================================
+ Hits 119229 119413 +184
- Misses 10926 10978 +52
- Partials 2679 2688 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tnull
approved these changes
Jun 18, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3478
On invoice_parameters_generated, explicitly mention that the intercept SCID needs to be retrieved from ChannelManager::get_intercept_scid
This PR documents and matches exactly what ldk-node is doing here https://github.com/lightningdevkit/ldk-node/blob/main/src/liquidity.rs#L554-L586